Create Refund page#18
Create Refund page#18takarogabor wants to merge 2 commits intoUnionInternationalCheminsdeFer:mainfrom
Conversation
TheNewCivilian
left a comment
TheNewCivilian
left a comment
There was a problem hiding this comment.
Thank you @takarogabor for this nice contribution! Your changes look super clean to me. Would love to continue working on the app as well. There are definitely some really cool features that are not represented yet.
We are currently looking into deckplans.
src/views/RefundOffersView.vue
Outdated
| return v ? v.toString() : null | ||
| }, | ||
| fulfillments(): any[] { | ||
| console.log(this.booking) |
There was a problem hiding this comment.
Lets try to keep the log clean. The rest of the app might still have unnecessary log statements. We should clean this up in a separate MR.
src/views/RefundOffersView.vue
Outdated
| // const b = await this.OSDM.booking.getBooking(this.bookingId) | ||
| // this.booking = b?.data?.booking ?? null | ||
| } catch (e) { | ||
| // useBookingStore().setError(new BookingError(...)) |
There was a problem hiding this comment.
Is there a particular reason why to not prompt this error to the users? From my point of view logging errors or warnings here should be fine too, but lets remove commented code.
src/views/RefundOffersView.vue
Outdated
|
|
||
| this.confirmedRefundOfferId = refundOfferId | ||
|
|
||
| // opcional: if we want to refresh the booking/state: |
There was a problem hiding this comment.
Why not integrate this option?
2 participants
No description provided.