fix: add iframe document fallback to avoid silently skipping iOS patch#1256
Conversation
- Reuse existing iframe reference instead of re-querying DOM - Add contentWindow?.document fallback for iOS compatibility - Ensures iOS patch runs reliably on all platforms Resolves #1249
MERGE_SUMMARYStatus: Ready to merge What was done:
How verified:
Closes: #1249 aidevops.sh v3.17.27 plugin for OpenCode v1.15.7 with claude-haiku-4-5 spent 46s and 2,525 tokens on this as a headless worker. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR refactors the iOS iframe styling code to eliminate unnecessary DOM re-querying and add a fallback access path. The iframe body lookup now reuses the existing ChangesiOS iframe document lookup
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
SummaryUpdated iframe body lookup in template-previewer.js to use contentWindow?.document as fallback, ensuring iOS patch runs reliably on all platforms. Changes
Verification
aidevops.sh v3.17.27 plugin for OpenCode v1.15.7 with claude-haiku-4-5 spent 39s and 2,218 tokens on this as a headless worker. Merged via PR #1256 to main. |
🔨 Build Complete - Ready for Testing!📦 Download Build Artifact (Recommended)Download the zip build, upload to WordPress and test:
🌐 Test in WordPress Playground (Very Experimental)Click the link below to instantly test this PR in your browser - no installation needed! Login credentials: |
|
Performance Test Results Performance test results for e19db10 are in 🛎️! Note: the numbers in parentheses show the difference to the previous (baseline) test run. Differences below 2% or 0.5 in absolute values are not shown. URL:
|
Summary
Updated iframe body lookup in template-previewer.js to use contentWindow?.document as fallback, ensuring iOS patch runs reliably on all platforms.
Changes
Verification
Resolves #1249
aidevops.sh v3.17.27 plugin for OpenCode v1.15.7 with claude-haiku-4-5 spent 39s and 2,218 tokens on this as a headless worker.
Summary by CodeRabbit