Open
Conversation
…tead of just machine data.
…-interface-machines
There was a problem hiding this comment.
Pull request overview
Adds a new Machines page and refactors shared “usage chart”/data types to support machine + job resource history displays in the web UI.
Changes:
- Introduces
Machine/JobTypeScript types (includingUsageData) and updates the Jobs route to use them. - Implements a
/machinesroute that renders machine cards with job lists and usage charts (sample-data loader for now). - Refactors
Chartto accept an array ofUsageDataand manage component pagination internally; addsdate-fnsfor date formatting.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| web-interface/src/types/machine.ts | Adds machine type definitions including machine-level usageHistory and job list. |
| web-interface/src/types/job.ts | Adds job type definitions and centralizes UsageData for charts. |
| web-interface/src/routes/machines.tsx | Implements Machines page UI and sample loader; displays machine/job info and charts. |
| web-interface/src/routes/jobs.tsx | Converts Jobs page to loader-driven sample data using new types; uses date-fns for formatting; updates chart usage. |
| web-interface/src/components/Chart.tsx | Changes chart API to accept UsageData[] and adds internal pagination state/controls. |
| web-interface/src/components/Buttons.tsx | Minor button class adjustment (adds pointer cursor). |
| web-interface/package.json | Adds date-fns dependency. |
| web-interface/bun.lock | Locks date-fns dependency resolution. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 9 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.