Skip to content

feat: rewrite Teaching Stats#89

Merged
Helias merged 201 commits intoUNICT-DMI:developmentfrom
ChiaraZuccaro:years-cds-teaching
Mar 20, 2026
Merged

feat: rewrite Teaching Stats#89
Helias merged 201 commits intoUNICT-DMI:developmentfrom
ChiaraZuccaro:years-cds-teaching

Conversation

@ChiaraZuccaro
Copy link
Copy Markdown
Collaborator

@ChiaraZuccaro ChiaraZuccaro commented Mar 18, 2026

Related to UNICT-Quality-Development/qd-projects#46

In this PR:

  • (MAIN) Teaching stats on selection (style will be improved);
  • Info disclaimers for OPIS groups (V1, V2, V3);
  • Unit tests for all utils;
  • Unit tests for graph.service and cds.service;
  • Buttons to switch graph type (disabled while loading);
  • Added descriptions for each graph type.

"tsConfig": "tsconfig.spec.json",
"coverage": true,
"coverageExclude": [
"**/*.html"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if it makes sense to exclude the *.html files

@Helias
Copy link
Copy Markdown
Member

Helias commented Mar 19, 2026

I think that what you are doing is more than the average request effort for this kind of project, you are rewriting the entire application, good job 🚀 💯 .

Tips:

  • make smaller PRs, so the review will be better, more detailed, and faster
  • would be great before making a new branch and PR to align the commit history, so update the fork with the upstream development branch (UNICT-DMI:development) and build on top of it, so the commit history will be compact and clear

@Helias Helias changed the title Teaching Stats feat: rewrite Teaching Stats Mar 20, 2026
@Helias Helias merged commit 0d5b71c into UNICT-DMI:development Mar 20, 2026
4 checks passed
@Helias
Copy link
Copy Markdown
Member

Helias commented Mar 20, 2026

I have found a bug testing it in https://unict-dmi.github.io/OPIS-Manager/development/department/matematica_e_informatica

I am afraid that the URL does not work properly, we should enable hashroute to fix it

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants