Open
Conversation
setup.py
Outdated
Member
There was a problem hiding this comment.
Think we should leave this as an optional dependency so it doesn't gum people up who don't plan to use it?
|
Changes Unknown when pulling 20bec6b on geopandas-explorer into * on master*. |
basically we monkey patch geopandas to have an explore method that calls dframe_explorer with all the right configuration. This is nice because geopandas * can convert to 4326 * has the center of the shapefile already * can read shapefiles rather than geojson into a leaflet map * can convert to geojson on the fly so that no file on the filesystem is required This also calls the webbrowser automatically when everything is ready
20bec6b to
7ef628c
Compare
…_explorer still needs a test for this new function
For now, I'm going to assume the shape being passed in is in epsg=4326.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
basically we monkey patch geopandas to have an explore method that calls dframe_explorer with all the right configuration.
This is nice because geopandas
This also calls the webbrowser automatically when everything is ready