Draft
Conversation
emilysxng
force-pushed
the
emily/hexray-ntp
branch
from
37ca726 to
f8bf5fa
Compare
…idated-Firmware into emily/hexray-ntp
…idated-Firmware into emily/hexray-ntp
Lucien950
reviewed
Apr 5, 2026
|
|
||
| void hw::Uart::onErrorFromISR() const | ||
| { | ||
| // just wake both up lmao |
Contributor
There was a problem hiding this comment.
this is indeed very suspicious but idk how to make this better
Contributor
Author
There was a problem hiding this comment.
I already made these changes locally 😭
Contributor
There was a problem hiding this comment.
Rip I thought Erik said you pushed all your changes already
Lucien950
requested changes
Apr 8, 2026
firmware/third_party/pybind11
Outdated
Contributor
|
LGTM 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.