This repository was archived by the owner on Aug 5, 2020. It is now read-only.
Open
Conversation
Added some things that weren't obvious to me the first time I tried to use the package. I also adjusted the indentation so it's clearer that the IndexRoute is actually wrapped by the RequireAuthContainer route. I'm not sure whether all routes below the container will be authorized as well, so feel free to fix that wording if it's not correct.
Contributor
|
Nice! I may piggyback a little more onto this because there were a few things I was realizing I left out |
jer-k
approved these changes
May 10, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added some things that weren't obvious to me the first time I tried to use the package.
I also adjusted the indentation so it's clearer that the IndexRoute is actually wrapped by the RequireAuthContainer route. I'm not sure whether all routes below the container will be authorized as well, so feel free to fix that wording if it's not correct.