Restructure context types and add AggregateOffer#71
Open
madman-81 wants to merge 6 commits intoTorann:1.0.0from
Open
Restructure context types and add AggregateOffer#71madman-81 wants to merge 6 commits intoTorann:1.0.0from
madman-81 wants to merge 6 commits intoTorann:1.0.0from
Conversation
…. Attributes in the $structure property are now automatically merged with all parent classes
…he actual setting of properties is now down inside the fill() function. This makes for easier unit testing in the future. * The makeProperty() is also able to handle nested contexts better. - If the $value contains @type, it will create a contact based on that type - $property can now contain an array of classes defining what types of nexted context may be used for that attribute of the main context - If $value hold and array of contexts, it will automatically make contexts for those. This was done in several context with a setter, these are now all obsolete and therefore removed * The Music related contexts have be reorganised and the mutual attributes have been moved to MusicAbstractContext
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solving #70, #68, #63, #49 and #27
And probably also #62,