Update Enter the Matrix Widescreen Fix for Patch v1.2#1648
Open
SiliconExarch wants to merge 1 commit intoThirteenAG:masterfrom
Open
Update Enter the Matrix Widescreen Fix for Patch v1.2#1648SiliconExarch wants to merge 1 commit intoThirteenAG:masterfrom
SiliconExarch wants to merge 1 commit intoThirteenAG:masterfrom
Conversation
SiliconExarch
force-pushed
the
ETM-v1.2-AIO
branch
from
a904ae9 to
001492f
Compare
Owner
|
Crashes with the version I have from back in the day:
|
Author
|
It's not expected to work for patch 1.52 anymore because the DVD-ROM edition and subsequent versions have significant code changes to the area in question on account of adding support for some additional (non-widescreen) resolutions. |
Owner
|
Then just split the code with if else. If pattern is found, patch it, else find another pattern and patch it. |
Owner
|
Alternatively you could just copy and paste the existing code to a separate RegisterCallback call, just make sure patterns are different in those and correspond with an appropriate exe. |
ThirteenAG
force-pushed
the
master
branch
2 times, most recently
from
097a674 to
312c00d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #774, patch 1.52 is not the newest available update for Enter The Matrix as Patch v1.2, which is 6 months newer than 1.52 and 2 months newer than the executable from the DVD-ROM Edition is available here.
This pull request updates the Widescreen Fix, accounting for the fact that depending on whether you install the CD Edition then update to 1.52 followed by v1.2 or install v1.2 on top of the DVD Edition you may have one of two different versions of
MatrixConfig.exe- in the end I was able to handle this without having to make separate versions of the fix for each scenario.