Open
Conversation
- sanitizer is adjusted; "unnamed" is tricky within golem so "" is kept - if checks for "" and _.R just in case sb. names the func. _, but the sanitizer should clean that actually
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1219
handle fct = "" correctly; include upstream fix #1207 via #1215 for easier cherry picking
brings in commit 8e7c30d to inherit the “sanitizer” logic.
adjust behavior so that fct = "" is treated as an empty string (not "unnamed"),
I dont like "unnamed" as internal name that propagates into golem-generated files; it seems to be difficult to handle as well; an empty func. name is probably just fine, as the original issue #1219 suggests.