Advanced Grid Properties: Add missing factors to grid content width calc#30971
Merged
mao-sz merged 2 commits intoTheOdinProject:mainfrom Apr 6, 2026
Merged
Advanced Grid Properties: Add missing factors to grid content width calc#30971mao-sz merged 2 commits intoTheOdinProject:mainfrom
mao-sz merged 2 commits intoTheOdinProject:mainfrom
Conversation
mao-sz
reviewed
Apr 6, 2026
Co-authored-by: mao-sz <122839503+mao-sz@users.noreply.github.com>
mao-sz
approved these changes
Apr 6, 2026
Contributor
|
You don't need to close anything - a maintainer will do what's needed when a PR is approved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
Text is missing the paddings, and borders of the grid when calculating it's content width. Also it says the browser has to know how wide our grid is but actually means how wide our grid's content width is.
This PR
Issue
Closes #30969
Additional Information
Pull Request Requirements
location of change: brief description of changeformat, e.g.Intro to HTML and CSS lesson: Fix link textBecausesection summarizes the reason for this PRThis PRsection has a bullet point list describing the changes in this PRIssuesection