Skip to content

Setting Up Git: Remove pull.rebase config step#30946

Merged
mao-sz merged 1 commit intoTheOdinProject:mainfrom
mao-sz:remove-pull-rebase
Mar 28, 2026
Merged

Setting Up Git: Remove pull.rebase config step#30946
mao-sz merged 1 commit intoTheOdinProject:mainfrom
mao-sz:remove-pull-rebase

Conversation

@mao-sz
Copy link
Copy Markdown
Contributor

@mao-sz mao-sz commented Mar 28, 2026

Because

As of Git v2.33.1, git pull will default to fast-forward with non-divergent branches, with no warning message.
The warning message about not specifying a reconciliation method as an option or in the config now only shows up if pulling into a divergent branch (rather than always), which would not be something intentionally done in TOP anyway (and we don't instruct to git pull anywhere either. Any lessons about pulling instead use fetching and merging as separate steps to be explicit).

See git/git@031e2f7

This PR

  • Removes the Git config step for setting a default pull.rebase value

Issue

Closes #30932

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

As of Git v2.33.1, `git pull` will default to fast-forward with
non-divergent branches.
The warning message about not specifying a reconciliation method as an
option or in the config now only shows up if pulling into a divergent
branch, which would not be something intentionally done in TOP anyway.
@github-actions github-actions bot added the Content: Foundations Involves the Foundations content label Mar 28, 2026
@mao-sz mao-sz merged commit 4a7da2b into TheOdinProject:main Mar 28, 2026
3 checks passed
@mao-sz mao-sz deleted the remove-pull-rebase branch March 28, 2026 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content: Foundations Involves the Foundations content

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setting Up Git: pull.rebase necessary?

2 participants