Open
Conversation
tolstenko
commented
Dec 2, 2022
tolstenko
commented
- Add more exclusions to gitignore
- Automated release - probably needs more improvements here, but it is good enough for most nightly scenarios
- Now tests are placed in just one action with matrix
TheLartians
requested changes
Feb 3, 2023
Owner
TheLartians
left a comment
TheLartians
left a comment
There was a problem hiding this comment.
Thanks for the PR!
I like the idea of merging the workflows into one for all systems. I'm not sure about the release script as it seems quite specific - maybe we could leave it out or add it at a later point?
Also could you update the badges in the readme to match the merged workflow files?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.