fix(issue-96): use oid_registry crate#97
Merged
TheBestTvarynka merged 1 commit intoTheBestTvarynka:mainfrom May 24, 2025
Merged
fix(issue-96): use oid_registry crate#97TheBestTvarynka merged 1 commit intoTheBestTvarynka:mainfrom
TheBestTvarynka merged 1 commit intoTheBestTvarynka:mainfrom
Conversation
Contributor
Author
|
Small warning, I have realized that this isn't exactly backwards compatible, as an example the oid |
TheBestTvarynka
approved these changes
May 17, 2025
Owner
TheBestTvarynka
left a comment
TheBestTvarynka
left a comment
There was a problem hiding this comment.
Hello,
Thank you for your PR 💟 . The code looks great to me. I'll test it tomorrow and then merge if everything is good.
Owner
|
@RageKnify I allowed the CI. Please, fix formatting ( |
TheBestTvarynka
added
enhancement
Introduce oid_registry as a dependency to manage the mapping of ASN1 oids. Closes TheBestTvarynka#96
RageKnify
force-pushed
the
refactor/oid-registry
branch
from
7c1574a to
9f64a9e
Compare
TheBestTvarynka
approved these changes
May 24, 2025
Owner
|
@RageKnify Thank you! |
TheBestTvarynka
pushed a commit
that referenced
this pull request
May 28, 2025
This reverts commit 0a0561a.
TheBestTvarynka
added a commit
that referenced
this pull request
May 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce oid_registry as a dependency to manage the mapping of ASN1 oids.
Closes #96