Cts fix improve automatic clustering#9637
Cts fix improve automatic clustering#9637luis201420 wants to merge 37 commits intoThe-OpenROAD-Project:masterfrom
Conversation
Signed-off-by: luis201420 <luisemv@precisioninno.com>
Signed-off-by: luis201420 <luisemv@precisioninno.com>
Signed-off-by: luis201420 <luisemv@precisioninno.com>
Signed-off-by: luis201420 <luisemv@precisioninno.com>
Signed-off-by: luis201420 <luisemv@precisioninno.com>
Signed-off-by: luis201420 <luisemv@precisioninno.com>
Signed-off-by: luis201420 <luisemv@precisioninno.com>
Signed-off-by: luis201420 <luisemv@precisioninno.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the automatic clustering logic in CTS. It simplifies the options by removing the ability to sweep through multiple cluster sizes and diameters. Instead, it introduces a new automatic mode where clustering is based on buffer max capacitance if the user does not specify both a cluster size and a max diameter. The changes in CtsOptions, HTreeBuilder, and SinkClustering are consistent with this new approach. I've added a couple of suggestions to improve code conciseness and readability.
Note: Security Review did not run due to the size of the PR.
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: luis201420 <luisemv@precisioninno.com>
Signed-off-by: luis201420 <luisemv@precisioninno.com>
Signed-off-by: luis201420 <luisemv@precisioninno.com>
Signed-off-by: luis201420 <luisemv@precisioninno.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: luis201420 <luisemv@precisioninno.com>
Signed-off-by: luis201420 <luisemv@precisioninno.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: luis201420 <luisemv@precisioninno.com>
Signed-off-by: luis201420 <luisemv@precisioninno.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: luis201420 <luisemv@precisioninno.com>
Signed-off-by: luis201420 <luisemv@precisioninno.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: luis201420 <luisemv@precisioninno.com>
Signed-off-by: luis201420 <luisemv@precisioninno.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: luis201420 <luisemv@precisioninno.com>
Signed-off-by: luis201420 <luisemv@precisioninno.com>
Signed-off-by: luis201420 <luisemv@precisioninno.com>
Signed-off-by: luis201420 <luisemv@precisioninno.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
arthurjolo
left a comment
arthurjolo
left a comment
There was a problem hiding this comment.
Code changes are Ok, is there a metrics PR already?
I am waiting for the new CI to finish running to verify the metrics PR. |
Signed-off-by: luis201420 <luisemv@precisioninno.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: luis201420 <luisemv@precisioninno.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: luis201420 <luisemv@precisioninno.com>
Signed-off-by: luis201420 <luisemv@precisioninno.com>
Signed-off-by: luis201420 <luisemv@precisioninno.com>
Signed-off-by: luis201420 <luisemv@precisioninno.com>
Signed-off-by: luis201420 <luisemv@precisioninno.com>
Signed-off-by: luis201420 <luisemv@precisioninno.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: luis201420 <luisemv@precisioninno.com>
Signed-off-by: luis201420 <luisemv@precisioninno.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: luis201420 <luisemv@precisioninno.com>
Signed-off-by: luis201420 <luisemv@precisioninno.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
2 participants
Fixes #8540
This includes reverted modifications of PR #8949
Additionally, modifications are included to use buffer max cap when performing macro clustering, which corrects the error caused by the PR revert.