cgt: adjust naming to Google-style (excluding method names)#10187
Merged
maliberty merged 1 commit intoThe-OpenROAD-Project:masterfrom Apr 19, 2026
Merged
Conversation
Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors member naming and header includes. It adds lint suppression for external ABC functions, renames private members in RandomBits.h to include trailing underscores, and removes trailing underscores from the visited member in ClockGating.cpp. Feedback was provided regarding the inclusion of base/abc/abc.h in ClockGatingImpl.h, suggesting that forward declarations should be maintained to avoid unnecessary compilation dependencies and improve build times.
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
maliberty
approved these changes
Apr 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
adjust naming to Google-style (excluding method names)
Type of Change
Impact
None
Verification
./etc/Build.sh).