add warn and error for placement density lower bound - #4486
Open
AcKoucher wants to merge 1 commit into
Open
Conversation
Signed-off-by: Arthur Koucher <arthurkoucher@precisioninno.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces validation checks for the placement density lower bound in flow/scripts/util.tcl. It adds an error message when the density lower bound is 1.0 or greater, indicating the design does not fit, and a warning when it exceeds 0.80. There are no review comments, so I have no feedback to provide.
Member
🔍 QoR checkMetrics reflect the PR merge build — i.e. what will land on the target branch. Advisory — results are log-only and do not affect build status. The authoritative QoR gate remains the local rules-file check. Commit 63 design(s) checked — 0 with regression(s), 1 without a comparable baseline.
|
oharboe
reviewed
Aug 29, 2026
| The design does not fit the core. Reduce CORE_UTILIZATION or\ | ||
| CELL_PAD_IN_SITES_GLOBAL_PLACEMENT." | ||
| } elseif { $place_density_lb > 0.80 } { | ||
| utl::warn FLW 26 \ |
Collaborator
There was a problem hiding this comment.
- why in ORFS and not OpenROAD?
- OpenROAD allocates error numbers. We did a sweep to get rid of error numbers in ORFS, why is it being re-introduced here? (Ask AI to check history...)
- CORE_UTILIZATION is [0, 100] and PLACE_DENSITY [0, 1] ranges. I don't think there's any reason it ended up this way, but it is not consistent and it is easy to confound these units.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.