Update metrics for The-OpenROAD-Project/OpenROAD#10261#4189
Merged
maliberty merged 1 commit intoThe-OpenROAD-Project:masterfrom Apr 25, 2026
Merged
Conversation
designs/gf12/bp_single/rules-base.json updates: | Metric | Old | New | Type | | ------ | --- | --- | ---- | | cts__timing__setup__ws | -100.0 | -632.0 | Failing | | cts__timing__setup__tns | -400.0 | -621000.0 | Failing | | cts__timing__hold__ws | -385.0 | -334.0 | Tighten | | cts__timing__hold__tns | -4460.0 | -5180.0 | Failing | | globalroute__timing__setup__ws | -100.0 | -289.0 | Failing | | globalroute__timing__setup__tns | -400.0 | -31300.0 | Failing | | globalroute__timing__hold__ws | -382.0 | -275.0 | Tighten | | globalroute__timing__hold__tns | -2210.0 | -577.0 | Tighten | | finish__timing__setup__ws | -109.0 | -227.0 | Failing | | finish__timing__setup__tns | -415.0 | -1670.0 | Failing | | finish__timing__hold__ws | -208.0 | -126.0 | Tighten | designs/gf12/ca53/rules-base.json updates: | Metric | Old | New | Type | | ------ | --- | --- | ---- | | cts__timing__setup__ws | -100.0 | -894.0 | Failing | | cts__timing__setup__tns | -400.0 | -4100.0 | Failing | designs/nangate45/bp_fe_top/rules-base.json updates: | Metric | Old | New | Type | | ------ | --- | --- | ---- | | cts__timing__setup__tns | -0.36 | -1.02 | Failing | | globalroute__timing__setup__tns | -0.396 | -0.362 | Tighten | | finish__timing__setup__ws | -0.206 | -0.161 | Tighten | | finish__timing__setup__tns | -20.5 | -0.685 | Tighten | designs/sky130hd/chameleon/rules-base.json updates: | Metric | Old | New | Type | | ------ | --- | --- | ---- | | placeopt__design__instance__count__stdcell | 59665 | 59456 | Tighten | | cts__timing__setup__ws | -2.19 | -0.962 | Tighten | | cts__timing__setup__tns | -34.8 | -6.72 | Tighten | | globalroute__antenna_diodes_count | 151 | 196 | Failing | | globalroute__timing__setup__ws | -2.24 | -0.944 | Tighten | | globalroute__timing__setup__tns | -10.2 | -5.91 | Tighten | | finish__timing__setup__ws | -2.28 | -0.916 | Tighten | | finish__timing__setup__tns | -9.59 | -7.59 | Tighten | designs/asap7/ibex/rules-base.json updates: | Metric | Old | New | Type | | ------ | --- | --- | ---- | | finish__timing__setup__tns | -722.0 | -960.0 | Failing | designs/nangate45/mempool_group/rules-base.json updates: | Metric | Old | New | Type | | ------ | --- | --- | ---- | | placeopt__design__instance__count__stdcell | 194613 | 188393 | Tighten | | globalroute__timing__setup__tns | -11400.0 | -14000.0 | Failing | | detailedroute__route__wirelength | 5508759 | 5273763 | Tighten | | finish__timing__setup__tns | -11300.0 | -11500.0 | Failing | | finish__timing__hold__tns | -1.16 | -0.738 | Tighten | designs/sky130hd/microwatt/rules-base.json updates: | Metric | Old | New | Type | | ------ | --- | --- | ---- | | synth__design__instance__area__stdcell | 689000.0 | 686000.0 | Tighten | | placeopt__design__instance__area | 5433922 | 5431496 | Tighten | | globalroute__antenna_diodes_count | 2635 | 1431 | Tighten | | detailedroute__antenna__violating__nets | 3 | 6 | Failing | | detailedroute__antenna_diodes_count | 1724 | 1688 | Tighten | | finish__timing__setup__tns | -148.0 | -145.0 | Tighten | | finish__timing__hold__tns | -22.1 | -15.3 | Tighten | | finish__design__instance__area | 5578282 | 5572106 | Tighten | designs/asap7/uart/rules-base.json updates: | Metric | Old | New | Type | | ------ | --- | --- | ---- | | finish__timing__setup__ws | -37.8 | -52.4 | Failing | Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the OpenROAD subproject and adjusts regression baselines for multiple designs across various platforms. While many changes reflect minor performance shifts, two significant regressions were identified: an extreme degradation in clock tree synthesis timing (TNS) for the bp_single design and a doubling of antenna violations in the microwatt design. These regressions suggest potential failures in the timing closure and antenna repair strategies that should be investigated before accepting the new baselines.
| }, | ||
| "cts__timing__setup__tns": { | ||
| "value": -400.0, | ||
| "value": -621000.0, |
There was a problem hiding this comment.
The relaxation of cts__timing__setup__tns from -400.0 to -621000.0 represents an extremely large regression (over 1500x). A TNS of this magnitude typically indicates a fundamental failure in the timing closure flow for this design/platform combination, such as a clock tree synthesis issue or incorrect timing constraints. Setting the baseline to such a degraded value effectively disables the utility of this regression test for catching future performance changes.
References
- When updating regression rules, ensure the committed data accurately reflects the intended results of the change. Discrepancies between the PR description and the updated rules should be investigated and explained.
Member
There was a problem hiding this comment.
Agreed but to be taken up afterwards
maliberty
approved these changes
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
designs/gf12/bp_single/rules-base.json updates:
designs/gf12/ca53/rules-base.json updates:
designs/nangate45/bp_fe_top/rules-base.json updates:
designs/sky130hd/chameleon/rules-base.json updates:
designs/asap7/ibex/rules-base.json updates:
designs/nangate45/mempool_group/rules-base.json updates:
designs/sky130hd/microwatt/rules-base.json updates:
designs/asap7/uart/rules-base.json updates: