metrics update after enabling negotiation legalizer#4156
Conversation
Signed-off-by: Jeff Ng <jeffng@precisioninno.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates timing and area metrics across multiple design rule files, primarily removing redundant finish stage metrics and adjusting cts and globalroute values. Significant regressions in setup and hold TNS were identified in the Hercules designs that require investigation. For consistency, the finish stage metrics should also be removed from the ethmac and gcd designs, as they were in other updated files.
| }, | ||
| "globalroute__timing__setup__tns": { | ||
| "value": -21.7, | ||
| "value": -97.2, |
There was a problem hiding this comment.
The globalroute__timing__setup__tns metric shows a significant regression from -21.7 to -97.2 (approx. 4.5x). If this degradation is not an expected consequence of the negotiation legalizer, it should be investigated.
| }, | ||
| "finish__timing__hold__tns": { | ||
| "value": -0.101, | ||
| "value": -0.703, |
There was a problem hiding this comment.
The globalroute__timing__hold__tns metric shows a significant regression from -0.101 to -0.703 (approx. 7x). If this degradation is not an expected consequence of the negotiation legalizer, it should be investigated.
| }, | ||
| "finish__timing__setup__tns": { | ||
| "value": -3.08, | ||
| "value": -3.11, |
There was a problem hiding this comment.
The finish__* metrics are being removed in most other designs (e.g., cva6, hercules, ibex, jpeg) where they are redundant with globalroute metrics. For consistency across the repository, consider removing the finish stage metrics here as well, as the values for ws and tns are identical to those in the globalroute stage.
| }, | ||
| "finish__timing__setup__tns": { | ||
| "value": -2.19, | ||
| "value": -2.59, |
There was a problem hiding this comment.
The finish__* metrics are being removed in most other designs where they are redundant with globalroute metrics. For consistency, consider removing the finish stage metrics here as well, as the timing values are identical to the globalroute stage and area tracking at the finish stage is being deprecated in other designs.
| }, | ||
| "finish__timing__setup__tns": { | ||
| "value": -1.1, | ||
| "value": -1.29, |
There was a problem hiding this comment.
The finish__* metrics are being removed in most other designs in this PR. For consistency, consider removing them here as well, as they are redundant with the globalroute stage metrics.
| }, | ||
| "finish__timing__setup__tns": { | ||
| "value": -1.72, | ||
| "value": -1.79, |
There was a problem hiding this comment.
The finish__* metrics are being removed in most other designs in this PR. For consistency, consider removing them here as well, as they are redundant with the globalroute stage metrics.
3 participants
Updated metrics after enabling negotiation legalizer for rapidus designs.
cva6 base
ethmac base
ethmac verific
gcd base
gcd verific
hercules_idecode base
hercules_idecode verific
hercules_is_int base
hercules_is_int verific
ibex base
ibex verific
jpeg base
jpeg verific