designs/gf12/aes/rules-base.json updates:#4153
Merged
maliberty merged 1 commit intoThe-OpenROAD-Project:masterfrom Apr 16, 2026
Merged
Conversation
Collaborator
openroad-ci
commented
Apr 16, 2026
openroad-ci
commented
| Metric | Old | New | Type |
|---|---|---|---|
| detailedroute__route__wirelength | 108230 | 126525 | Failing |
| Metric | Old | New | Type | | ------ | --- | --- | ---- | | detailedroute__route__wirelength | 108230 | 126525 | Failing | Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the wirelength constraint for the GF12 AES design in the rules-base.json file, increasing the threshold from 108230 to 126525. Feedback indicates that this 17% increase is a significant regression in the Quality of Results (QoR) and could potentially mask underlying efficiency issues within the physical design flow.
| }, | ||
| "detailedroute__route__wirelength": { | ||
| "value": 108230, | ||
| "value": 126525, |
There was a problem hiding this comment.
This significant regression in wirelength (~17%) degrades the Quality of Results (QoR) tracking for this design. Relaxing constraints to this extent masks potential efficiency issues in the physical design flow.
maliberty
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.