Add ORFS variable to enable negotiation-based legalizer#4151
Closed
openroad-ci wants to merge 6 commits intoThe-OpenROAD-Project:masterfrom
Closed
Add ORFS variable to enable negotiation-based legalizer#4151openroad-ci wants to merge 6 commits intoThe-OpenROAD-Project:masterfrom
openroad-ci wants to merge 6 commits intoThe-OpenROAD-Project:masterfrom
Conversation
Signed-off-by: Cho Moon <cmoon@precisioninno.com>
Signed-off-by: Cho Moon <cmoon@precisioninno.com>
Signed-off-by: Cho Moon <cmoon@precisioninno.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the ENABLE_NB_LEGALIZER configuration variable to support negotiation-based legalization during detailed placement. The changes include updates to documentation, the variables schema, and several Tcl scripts to conditionally apply the -use_negotiation flag. Review feedback highlights that the log_cmd wrapper was inadvertently removed in cts.tcl and detail_place.tcl, which would prevent these commands from being properly logged in the flow metrics. Additionally, a typo was identified in the description of the new variable in variables.yaml.
Signed-off-by: Cho Moon <cmoon@precisioninno.com>
Signed-off-by: Cho Moon <cmoon@precisioninno.com>
Signed-off-by: Cho Moon <cmoon@precisioninno.com>
Member
|
Dup of #4147 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.