Skip to content

[Outliner]: updateGroup accepts _delta but never applies it? dead code?Β #800

Description

@ShaMan123

Describe the bug πŸ“

_delta is never referenced in the function, it seems like dead code from pre-group era.
The outliner logic changes the state.map attr and that is used by updateGroup:

private async updateGroup(name: string, _delta?: OBC.ModelIdMap) {
const state = this.ensureGroup(name);
if (!this.world) return;
const renderer = this.getRenderer();
const pass = renderer.postproduction.outlinePass;
// Make sure the pass knows about this group (palette + material +
// container). The Outliner's ensureGroup only tracks selection state.
if (!pass.hasGroup(name)) pass.addGroup(name);
if (name === DEFAULT_GROUP && this.outlinePositions) {
await this.updatePoints();
}
const fragments = this.components.get(OBC.FragmentsManager);
const map = state.map;

Reproduction ▢️

No response

Steps to reproduce πŸ”’

No response

System Info πŸ’»

/

Used Package Manager πŸ“¦

npm

Error Trace/Logs πŸ“ƒ

No response

Validations βœ…

  • Read the docs.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Make sure this is a repository issue and not a framework-specific issue. For example, if it's a THREE.js related bug, it should likely be reported to mrdoob/threejs instead.
  • Check that this is a concrete bug. For Q&A join our Community.
  • The provided reproduction is a minimal reproducible example of the bug.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions