Describe the bug π
_delta is never referenced in the function, it seems like dead code from pre-group era.
The outliner logic changes the state.map attr and that is used by updateGroup:
|
private async updateGroup(name: string, _delta?: OBC.ModelIdMap) { |
|
const state = this.ensureGroup(name); |
|
if (!this.world) return; |
|
const renderer = this.getRenderer(); |
|
const pass = renderer.postproduction.outlinePass; |
|
|
|
// Make sure the pass knows about this group (palette + material + |
|
// container). The Outliner's ensureGroup only tracks selection state. |
|
if (!pass.hasGroup(name)) pass.addGroup(name); |
|
|
|
if (name === DEFAULT_GROUP && this.outlinePositions) { |
|
await this.updatePoints(); |
|
} |
|
|
|
const fragments = this.components.get(OBC.FragmentsManager); |
|
const map = state.map; |
Reproduction βΆοΈ
No response
Steps to reproduce π’
No response
System Info π»
Used Package Manager π¦
npm
Error Trace/Logs π
No response
Validations β
Describe the bug π
_deltais never referenced in the function, it seems like dead code from pre-group era.The outliner logic changes the
state.mapattr and that is used byupdateGroup:engine_components/packages/front/src/fragments/Outliner/index.ts
Lines 455 to 470 in 1d8ca36
ReproductionβΆοΈ
No response
Steps to reproduce π’
No response
System Info π»
Used Package Manager π¦
npm
Error Trace/Logs π
No response
Validations β