Harden storage cleanup and disk admission#642
Closed
Th0rgal wants to merge 2 commits into
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Owner
Author
|
Superseded by #643, rebuilt from the updated master so the PR contains only the storage-hardening commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
The production host hit ENOSPC twice even though workspace GC was enabled. GC ran only hourly, retained terminal work for seven days, reclaimed only standard mission directories, and admitted almost every mission without a disk estimate until the filesystem reached the critical threshold. Large parallel Lean/build fan-outs could consume the remaining capacity before the next sweep.
Production impact
This keeps execution opt-in through
WORKSPACE_GC_EXECUTE, but makes enabled cleanup substantially faster and shorter-lived. Dedicated build hosts can refuse admission at Warn and assign a fail-safe estimate to requests that omit one. Remote-node work remains available during local disk pressure.Validation
cargo fmt --all --checkcargo checkcargo test mission_workspace_gc --lib(5 passed)cargo test disk_estimate_preserves_emergency_free_space --lib(1 passed)bash -n scripts/storage_hard_cleanup.shgit diff --check