Clamp anchored scroll offset for short content#6654
Open
vamsikrishnap23 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6652.
When an anchored
VerticalScrollcontains less content than the viewport,the compositor computes the anchored scroll position as:
If the content is shorter than the viewport, this value becomes negative.
Because it is assigned directly using
set_reactive, it bypasses the normalscroll validation, allowing
scroll_yto become negative. This causes theanchored content to render with empty space above it instead of remaining
aligned to the top of the viewport.
This change clamps the computed anchored scroll offset to
0before it isapplied, preventing invalid negative scroll positions while preserving the
existing anchoring behavior for content that exceeds the viewport height.
Changes
0insrc/textual/_compositor.py.VerticalScrollwith content shorter than the viewport.Test plan
mainwithout the fix:tests/test_containers.pysuite:Checklist
CHANGELOG.mdblack --check