Allow nested brackets in markup.escape tag matching#6650
Open
Devil1716 wants to merge 1 commit into
Open
Conversation
The previous character class [^[] rejected any tag-like segment that contained a nested '[', so strings like Pydantic error messages were left unescaped and later raised MarkupError in to_content. Match until the closing ']' instead. Fixes Textualize#6614 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
markup.escapetag regex from[^[]to[^\]]so outer tags containing nested[are escaped.Test plan
pytest tests/test_markup.py::test_escape_nested_bracketspytest tests/test_markup.pyFixes #6614