Skip to content

shink vulkan shader#6479

Merged
nihui merged 6 commits intoTencent:masterfrom
futz12:shrink_vulka
Feb 25, 2026
Merged

shink vulkan shader#6479
nihui merged 6 commits intoTencent:masterfrom
futz12:shrink_vulka

Conversation

@futz12
Copy link
Copy Markdown
Contributor

@futz12 futz12 commented Jan 2, 2026

No description provided.

@github-actions github-actions bot added the vulkan label Jan 2, 2026
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.21%. Comparing base (9bd6551) to head (b47eb27).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6479      +/-   ##
==========================================
- Coverage   93.23%   93.21%   -0.02%     
==========================================
  Files         852      853       +1     
  Lines      267286   267495     +209     
==========================================
+ Hits       249195   249345     +150     
- Misses      18091    18150      +59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tencent-adm
Copy link
Copy Markdown
Member

tencent-adm commented Feb 2, 2026

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ futz12
❌ nihui
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a Vulkan backend implementation for the existing Shrink layer by introducing a Vulkan pipeline wrapper and a corresponding compute shader, enabling GPU execution for this operator.

Changes:

  • Added Shrink_vulkan layer class with pipeline lifecycle management (create_pipeline / destroy_pipeline) and Vulkan forward_inplace.
  • Added Vulkan compute shader shrink.comp implementing the Shrink operation for VkMat buffers.
  • Introduced new Vulkan layer header/implementation files for integration with the existing Vulkan layer system.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/layer/vulkan/shrink_vulkan.h Declares Shrink_vulkan Vulkan layer wrapper and its pipeline member.
src/layer/vulkan/shrink_vulkan.cpp Implements pipeline creation/destruction and dispatch for Shrink on Vulkan.
src/layer/vulkan/shader/shrink.comp Implements Shrink in GLSL compute shader with specialization constants for parameters.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@nihui nihui merged commit 1ac3e4d into Tencent:master Feb 25, 2026
73 of 75 checks passed
@nihui
Copy link
Copy Markdown
Member

nihui commented Feb 25, 2026

Thanks for your contribution !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants