Matmul vulkan shader by futz12 · Pull Request #6470 · Tencent/ncnn

futz12 · 2025-12-29T07:40:36Z

No description provided.

# Conflicts: # src/layer/vulkan/matmul_vulkan.cpp

codecov-commenter · 2025-12-29T08:00:26Z

Codecov Report

❌ Patch coverage is 96.49805% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.91%. Comparing base (06c4da1) to head (3b75b93).

Files with missing lines	Patch %	Lines
src/layer/vulkan/matmul_vulkan.cpp	96.49%	9 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##           master    #6470    +/-   ##
========================================
  Coverage   95.90%   95.91%            
========================================
  Files         845      846     +1     
  Lines      265399   265600   +201     
========================================
+ Hits       254531   254741   +210     
+ Misses      10868    10859     -9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot

Pull request overview

This PR adds Vulkan shader support for matrix multiplication operations to the ncnn framework. The implementation provides GPU acceleration for matmul operations using Vulkan compute shaders.

Implements a new Vulkan compute shader for matrix multiplication with support for transposed matrices and batched operations
Adds MatMul_vulkan class following the established pattern for Vulkan layer implementations
Handles multiple input dimensions (1D through 4D tensors) with appropriate broadcasting

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 9 comments.

File	Description
src/layer/vulkan/shader/matmul.comp	New Vulkan compute shader implementing matrix multiplication with local memory optimization and support for various tensor dimensions
src/layer/vulkan/matmul_vulkan.h	Header file declaring the MatMul_vulkan class with standard Vulkan layer interface
src/layer/vulkan/matmul_vulkan.cpp	Implementation of MatMul_vulkan class handling dimension calculations, tensor broadcasting, and pipeline dispatch

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/layer/vulkan/matmul_vulkan.cpp

Copilot · 2025-12-29T09:55:59Z

src/layer/vulkan/shader/matmul.comp

+                if (in_m0)
+                a0 = lfp(buffer_ld1(a_blob_data, a_base + m0 * p.a_w + ak));
+                if (in_m1)
+                a1 = lfp(buffer_ld1(a_blob_data, a_base + (m0 + 1) * p.a_w + ak));


The statements inside these if blocks are missing proper indentation. They should be indented to match the code style used elsewhere in the file.

Copilot · 2025-12-29T09:55:59Z

src/layer/vulkan/shader/matmul.comp

+                    if (transB == 0)
+                    b_idx0 = b_base + bk * p.b_w + n0;
+                    else
+                    b_idx0 = b_base + n0 * p.b_w + bk;


The statements inside these if blocks are missing proper indentation. They should be indented to match the code style used elsewhere in the file.

Copilot · 2025-12-29T09:55:59Z

src/layer/vulkan/matmul_vulkan.h

@@ -0,0 +1,28 @@
+// Copyright 2025 pchar.cn


The copyright format is inconsistent with other files by the same author. Other files in this directory use "Copyright 2025 Futz12 <pchar.cn>" (e.g., layernorm_vulkan.h, rmsnorm_vulkan.h). Consider using the same format for consistency.

Suggested change

// Copyright 2025 pchar.cn

// Copyright 2025 Futz12 <pchar.cn>

Copilot · 2025-12-29T09:56:00Z

src/layer/vulkan/matmul_vulkan.cpp

@@ -0,0 +1,411 @@
+// Copyright 2025 pchar.cn


The copyright format is inconsistent with other files by the same author. Other files in this directory use "Copyright 2025 Futz12 <pchar.cn>" (e.g., layernorm_vulkan.cpp, rmsnorm_vulkan.cpp). Consider using the same format for consistency.

Suggested change

// Copyright 2025 pchar.cn

// Copyright 2025 Futz12 <pchar.cn>

Copilot · 2025-12-29T09:56:00Z

src/layer/vulkan/shader/matmul.comp

@@ -0,0 +1,384 @@
+// Copyright 2025 pchar.cn


The copyright format is inconsistent with other shader files by the same author. Other shader files in this directory use "Copyright 2025 Futz12 <pchar.cn>" (e.g., layernorm_.comp, rmsnorm_.comp). Consider using the same format for consistency.

Suggested change

// Copyright 2025 pchar.cn

// Copyright 2025 Futz12 <pchar.cn>

Copilot · 2025-12-29T09:56:00Z

src/layer/vulkan/shader/matmul.comp

+        bool in_m0; // = (m0 < p.out_h);
+        bool in_m1; // = (m0 + 1 < p.out_h);
+        bool in_n0; // = (n0 < p.out_w);
+        bool in_n1; // = (n0 + 1 < p.out_w);
+
+        if (m0 < p.out_h)
+            in_m0 = true;
+        else
+            in_m0 = false;
+
+        if (m0 + 1 < p.out_h)
+            in_m1 = true;
+        else
+            in_m1 = false;
+
+        if (n0 < p.out_w)
+            in_n0 = true;
+        else
+            in_n0 = false;
+
+        if (n0 + 1 < p.out_w)
+            in_n1 = true;
+        else
+            in_n1 = false;
+


The boolean assignments can be simplified. Instead of using if-else statements to assign true/false, directly use the comparison result.

Suggested change

bool in_m0; // = (m0 < p.out_h);

bool in_m1; // = (m0 + 1 < p.out_h);

bool in_n0; // = (n0 < p.out_w);

bool in_n1; // = (n0 + 1 < p.out_w);

if (m0 < p.out_h)

in_m0 = true;

else

in_m0 = false;

if (m0 + 1 < p.out_h)

in_m1 = true;

else

in_m1 = false;

if (n0 < p.out_w)

in_n0 = true;

else

in_n0 = false;

if (n0 + 1 < p.out_w)

in_n1 = true;

else

in_n1 = false;

bool in_m0 = (m0 < p.out_h);

bool in_m1 = (m0 + 1 < p.out_h);

bool in_n0 = (n0 < p.out_w);

bool in_n1 = (n0 + 1 < p.out_w);

Copilot · 2025-12-29T09:56:00Z

src/layer/vulkan/shader/matmul.comp

+                    if (transB == 0)
+                    b_idx1 = b_base + bk * p.b_w + (n0 + 1);
+                    else
+                    b_idx1 = b_base + (n0 + 1) * p.b_w + bk;


The statements inside these if blocks are missing proper indentation. They should be indented to match the code style used elsewhere in the file.

src/layer/vulkan/matmul_vulkan.cpp

tencent-adm · 2026-01-03T07:51:50Z

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ futz12
❌ nihui
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

futz12 and others added 4 commits December 29, 2025 14:18

matmul vulkan impl

65d1d9d

apply code-format changes

5e2785c

matmul vulkan shared memory

9d0b32a

Merge remote-tracking branch 'origin/matmul-vulkan2' into matmul-vulkan2

deaa605

# Conflicts: # src/layer/vulkan/matmul_vulkan.cpp

github-actions bot added the vulkan label Dec 29, 2025

futz12 and others added 3 commits December 29, 2025 07:41

apply code-format changes

8733fc5

update Copyright

a1beac5

Merge remote-tracking branch 'origin/matmul-vulkan2' into matmul-vulkan2

d3259c5

nihui requested a review from Copilot December 29, 2025 09:48

Copilot started reviewing on behalf of nihui December 29, 2025 09:48 View session

Copilot AI reviewed Dec 29, 2025

View reviewed changes

futz12 and others added 2 commits December 29, 2025 20:56

update codestyle

13fc30d

Merge branch 'master' into matmul-vulkan2

3f7349e

apply code-format changes

3b75b93

nihui closed this Jan 3, 2026

nihui reopened this Jan 3, 2026

	// Copyright 2025 pchar.cn
	// Copyright 2025 Futz12 <pchar.cn>

Conversation

futz12 commented Dec 29, 2025

Uh oh!

codecov-commenter commented Dec 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI Dec 29, 2025

Choose a reason for hiding this comment

Uh oh!

futz12 Jan 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 29, 2025

Choose a reason for hiding this comment

Uh oh!

futz12 Jan 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 29, 2025

Choose a reason for hiding this comment

Uh oh!

futz12 Jan 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 29, 2025

Choose a reason for hiding this comment

Uh oh!

futz12 Jan 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 29, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tencent-adm commented Jan 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov-commenter commented Dec 29, 2025 •

edited

Loading