fix(ota): redact credential hints in multi-search adapter errors#121
Merged
Conversation
Sanitize per-adapter error strings in SourceStatus before returning them to HTTP clients. Adds regression test. Ports BUG-003 fix from private QA — no QA/ artifacts. Co-authored-by: telivity-otaip <telivity-otaip@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports the BUG-003 security fix
When a multi-adapter search fails, adapter error messages are sanitized before inclusion in
sources[].errorso credential hints (API keys, secrets, tokens) are not exposed to HTTP clients.Changes
examples/ota/src/services/multi-search-service.ts— addsanitizeAdapterError()examples/ota/src/__tests__/multi-search-sanitize.test.ts— regression testTest plan
pnpm vitest run examples/ota/src/__tests__/multi-search-sanitize.test.tspnpm test(full suite in CI)