0.5.0: remove the deprecated authoring surface — converge on definition - #7
Merged
Conversation
Delete typed-activity and versioning (modules and package exports); drop the mailbox/update/state-cell exports and their make constructors (the modules stay internal wire homes); privatize engine-sandbox's per-primitive machinery (callActivity, takeMailbox, pollMailbox, takeUpdate, setStateCell, sleepUntil, continueAsNew, the UpdateRequest alias) behind the Temporal WorkflowOps runtime. deprecateVersion/deprecatePatch/patched move to bundle. prefer-definition keeps its tables so a stale import gets a pointer, and now also flags workflowBundle imported from engine-sandbox. Replay drill: two histories recorded on 0.4.0 (versioned + executeChild; timer racing a mailbox take) replay alongside the 0.3.0 one. The version-chain fixtures author with versioned; generation 1 stays pre-versioning code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The deletion release planned in 0.4.0's changelog. Everything deprecated there is gone; the API converges on
definition+bundle+activities+client/engine-client+testing(+wireand the engine-level corners ofengine-sandbox).typed-activityandversioningmodules and package exports.deprecateVersion/deprecatePatch/patched(Temporal-only retirement step) now live inbundle.engine-sandbox:callActivity,takeMailbox,pollMailbox,takeUpdate,setStateCell,sleepUntil,continueAsNew, theUpdateRequest<S, E, P>alias — now module-private machinery behind the TemporalWorkflowOpsruntime.workflowBundle(import frombundle),callRawActivity, workflow→workflowofferMailbox,callNexusWorkflowOperation,SandboxRunremain.mailbox/update/state-cellpackage exports and theirmakeconstructors; the modules stay in-tree as internal wire homes.prefer-definitionkeeps its tables (message: "was removed in 0.5.0 — use …") so a stale import gets a pointer, and also reportsworkflowBundlefromengine-sandbox. Deviation from the 0.4.0 plan (which said to empty the tables), noted in the changelog.Wire safety
No wire change.
replay-compat.test.tsnow replays three recorded histories through this bundle:defOrder(0.3.0), and two recorded on 0.4.0 before this deletion —defDispatch(versionedmarker + awaitedexecuteChild) anddefGrace(durable timer racing a mailbox take). The version-chain fixtures (generations 2 and 3) author withversioned; generation 1 stays pre-versioning code, so the three-generation replay drill still proves adoption is replay-safe.Validation
src/orexamples/;examples/has zeroengine-sandboximports