Skip to content

Conversation

@thompson-tomo
Copy link

Closes #52

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're grateful you made your first pull request notification. You can be sure that a response will be made as soon as possible.

This comment was marked as outdated.

@Taiizor Taiizor requested a review from Copilot June 20, 2025 21:12
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR switches the package licensing metadata from a file-based approach to an SPDX license expression (MIT) across all project files, and removes the explicit packaging of the LICENSE file.

  • Replaced <PackageLicenseFile> entries with <PackageLicenseExpression>MIT</PackageLicenseExpression>
  • Removed <None Include="..\..\LICENSE">…</None> sections to stop packaging the standalone LICENSE file
  • Applied the same change consistently across all UUID and serialization subproject .csproj files

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/UUID/UUID.csproj Set license expression to MIT and removed license file packaging
src/UUID.Serialization.System/UUID.Serialization.System.csproj Set license expression to MIT and removed license file packaging
src/UUID.Serialization.Newtonsoft/UUID.Serialization.Newtonsoft.csproj Set license expression to MIT and removed license file packaging
src/UUID.Serialization.MessagePack/UUID.Serialization.MessagePack.csproj Set license expression to MIT and removed license file packaging
src/UUID.Serialization.Entity/UUID.Serialization.Entity.csproj Set license expression to MIT and removed license file packaging
src/UUID.Serialization.Dapper/UUID.Serialization.Dapper.csproj Set license expression to MIT and removed license file packaging
Comments suppressed due to low confidence (2)

src/UUID/UUID.csproj:24

  • [nitpick] Consider adding or updating a license badge in the README.md to reflect the new MIT license declaration in package metadata, ensuring consumers see the license upfront.
        <PackageLicenseExpression>MIT</PackageLicenseExpression>

src/UUID/UUID.csproj:24

  • [nitpick] The MIT license expression is duplicated in every project file; you could centralize this in a shared Directory.Build.props to reduce repetition and simplify future license updates.
        <PackageLicenseExpression>MIT</PackageLicenseExpression>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Switch to licence expression

2 participants