Skip to content

Override synchronous Process in AnchorTagHelper subclasses#2207

Closed
YoshiRulz wants to merge 1 commit intoTASVideos:mainfrom
YoshiRulz:tag-helper-process-fix
Closed

Override synchronous Process in AnchorTagHelper subclasses#2207
YoshiRulz wants to merge 1 commit intoTASVideos:mainfrom
YoshiRulz:tag-helper-process-fix

Conversation

@YoshiRulz
Copy link
Copy Markdown
Collaborator

See #2197 (comment) for explanation.
I've attempted to implement these 1) without simply calling ProcessAsync from Process, which adelikat didn't like, and 2) while minimising code duplication.

@YoshiRulz YoshiRulz force-pushed the tag-helper-process-fix branch from 9ea3def to 5924f8b Compare December 18, 2025 04:16
@Masterjun3
Copy link
Copy Markdown
Collaborator

I read the comment, but why exactly do we need this? Do we have a specific use case, or is this a "just in case"?

@Masterjun3
Copy link
Copy Markdown
Collaborator

From what I see, some of the asp net core tag helpers also don't override Process. So I would probably close and leave this unmerged if we don't need it.

@YoshiRulz
Copy link
Copy Markdown
Collaborator Author

It's a "just in case" which I already ran into in practice while writing unit tests.

Looks like the unit tests for ScriptTagHelper are all async. I suspect that they would see odd failures if they made those synchronous for some reason.

@Masterjun3
Copy link
Copy Markdown
Collaborator

I'm in favor of not adding in this complexity if not even asp net core code cares about that.
It only matters to us in the tests (in the other PR), and we're already copying unit test code from the asp net core repository anyway, so that's covered.

@Masterjun3 Masterjun3 closed this Mar 18, 2026
@YoshiRulz YoshiRulz deleted the tag-helper-process-fix branch March 18, 2026 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants