Override synchronous Process in AnchorTagHelper subclasses#2207
Closed
YoshiRulz wants to merge 1 commit intoTASVideos:mainfrom
Closed
Override synchronous Process in AnchorTagHelper subclasses#2207YoshiRulz wants to merge 1 commit intoTASVideos:mainfrom
Process in AnchorTagHelper subclasses#2207YoshiRulz wants to merge 1 commit intoTASVideos:mainfrom
Conversation
9ea3def to
5924f8b
Compare
Collaborator
|
I read the comment, but why exactly do we need this? Do we have a specific use case, or is this a "just in case"? |
Collaborator
|
From what I see, some of the asp net core tag helpers also don't override |
Collaborator
Author
|
It's a "just in case" which I already ran into in practice while writing unit tests. Looks like the unit tests for |
Collaborator
|
I'm in favor of not adding in this complexity if not even asp net core code cares about that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #2197 (comment) for explanation.
I've attempted to implement these 1) without simply calling
ProcessAsyncfromProcess, which adelikat didn't like, and 2) while minimising code duplication.