Open
Conversation
Author
|
Hi, did anyone have a chance to look at this? Should I change something about it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had this lying around and cleaned up a bit. I see there is another PR in limbo, this takes a bit different approach. Enums are emitted as #defines, because IMHO that's the safe way (C enumerators are signed integers etc.). Some fiddling was needed to get scope prefixes sensible; as you can define an enum with the same type name in different scopes. Also allows a "global" enum if you define it at root or "high enough" in the hierarchy.