consolidate settings - #79
Merged
Merged
Conversation
KrisThielemans
requested changes
Feb 27, 2026
casperdcl
force-pushed
the
tidy-settings
branch
from
February 27, 2026 15:32
4b2b2b2 to
af37117
Compare
- vmax default None - dataset_settings.DATA single source of truth
casperdcl
force-pushed
the
tidy-settings
branch
from
February 27, 2026 15:35
af37117 to
eb77f15
Compare
KrisThielemans
left a comment
KrisThielemans
left a comment
Member
There was a problem hiding this comment.
Looks ok now, but I wonder about the removal of PETRIC_SKIP_DATA. The main reason it was useful for me is that it didn't load any data when importing petric, and (I believe) it didn't create any metrics and therefore tensorboards. That made a large improvement (and didn't create all the tensorboard directories).
I haven't carefully checked the logic now if this remains the case or not. If you think we no longer need PETRIC_SKIP_DATA, then it might have to be removed from some doc somewhere.
casperdcl
commented
Mar 3, 2026
casperdcl
left a comment
casperdcl
left a comment
Member
Author
There was a problem hiding this comment.
re-add PETRIC_SKIP_DATA
KrisThielemans
approved these changes
Mar 3, 2026
KrisThielemans
left a comment
KrisThielemans
left a comment
Member
There was a problem hiding this comment.
looks ok, but I haven't tried it :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vmaxdefaultNone(not-1)dataset_settings.DATAsingle source of truth