refactor: deep cleanup and critical bug fixes#60
Merged
Conversation
## Breaking Changes - Removed deprecated exports from @sylphx/rosetta: - `./server` entry point (use @sylphx/rosetta-next/server) - `./adapters` entry point (legacy) - Removed deprecated exports from @sylphx/rosetta-next: - `./loader` entry point - `./sync` entry point - Deprecated functions: getDefaultLocale, getLocaleChain, getTranslationsAsync ## Bug Fixes - fix(rosetta-next): Armenian locale data corruption (Հdelays → Հdelays) - fix(rosetta-next): option parsing false positive when params contain 'context' key - fix(rosetta-next): Edge runtime crash with process.env (3 locations) - fix(rosetta-admin): useAdminState infinite re-render with inline selectors - fix(rosetta-translator-openrouter): unprotected JSON.parse crash on malformed response ## Improvements - refactor(rosetta): document MAX_TEXT_LENGTH difference (10KB validation vs 50KB ICU) - refactor(rosetta): fix CLI build output path to dist/cli - refactor(rosetta-next): extract shared locale constants to avoid duplication - refactor(rosetta-drizzle): document non-atomic deleteSource operation ## Removed (Legacy/Unused) - packages/rosetta/src/server/ (moved to rosetta-next) - packages/rosetta/src/adapters/ (legacy) - packages/rosetta-next/src/loader.ts - packages/rosetta-next/src/sync.ts - packages/rosetta-next/src/server-provider.tsx - Associated test files for removed modules
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bug Fixes
Հdelays→Հdelays(correct Armenian script)t("Hello {context}", {context: "world"})now works correctlyprocess.envchecks for Cloudflare Workers/Deno DeployuseAdminStatehook when using inline selectorsBreaking Changes
@sylphx/rosetta/server(use@sylphx/rosetta-next/server)@sylphx/rosetta/adapters(legacy)@sylphx/rosetta-next/loaderand@sylphx/rosetta-next/syncexportsgetDefaultLocale,getLocaleChain,getTranslationsAsyncTest plan