feat(valkeystore): add Valkey-backed Store#180
Open
YimingIsCOLD wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Summary
Adds
session/valkeystore, a Valkey-backed implementation ofsession.Storefor production deployments where session state must outlive a single process. Snapshots are JSON-encoded under a caller-configurable key prefix and expire server-side when their TTL elapses.✏️ Changes
server/internal/session/valkeystorepackage implementingPrepare,Commit, andDropagainst thevalkey-glide/go/v2client; default key prefixsession:(override withWithPrefix).testcontainers-go(imagevalkey/valkey:9.0-alpine, latest version supported by AWS ElastiCache). One container perTest<...>function; per-subtest isolation viat.Name()-derived prefixes.CONTRIBUTING.md: clarified thatwant/gotmay name top-level multi-value captures when no if-init binding is used; semantic names still required when if-init bindswant/got.memstore_test.go: alignedTestStore_PrepareandTestStore_Commitshape withvalkeystore_test.go(foldedTestStore_TTLinto Prepare, mirrored subtest order, renamed locals to the newwant/gotpattern).🧪 Test Plan
go test ./server/internal/session/...(memstore, valkeystore, and parent session package all pass)go test -race ./server/internal/session/memstore/(concurrent access subtest)go test -race ./server/internal/session/valkeystore/(testcontainer-backed)make lint(0 issues)