Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #96 +/- ##
=======================================
Coverage 100.0% 100.0%
=======================================
Files 13 13
Lines 747 777 +30
Branches 65 65
=======================================
+ Hits 747 777 +30 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Stormheg
force-pushed
the
feature/38-use-webauthn-signal-api
branch
2 times, most recently
from
643e81f to
2a840eb
Compare
Stormheg
added a commit
to Stormheg/django-otp-webauthn
that referenced
this pull request
Nov 22, 2025
Stormheg
added a commit
to Stormheg/django-otp-webauthn
that referenced
this pull request
Nov 22, 2025
Stormheg
force-pushed
the
feature/38-use-webauthn-signal-api
branch
from
461f2a6 to
4d7af41
Compare
Stormheg
added a commit
to Stormheg/django-otp-webauthn
that referenced
this pull request
Nov 22, 2025
Stormheg
force-pushed
the
feature/38-use-webauthn-signal-api
branch
from
4d7af41 to
39f3153
Compare
activus-d
reviewed
Nov 25, 2025
Comment on lines
+120
to
+140
| How does this work from a technical perspective? | ||
| ------------------------------------------------ | ||
|
|
||
| The ``render_otp_webauthn_sync_signals_scripts`` template tag is a convenience | ||
| wrapper that ends up calling the | ||
| ``PublicKeyCredential.signalAllAcceptedCredentials`` and | ||
| ``PublicKeyCredential.signalCurrentUserDetails`` WebAuthn browser APIs. It | ||
| automatically retrieves a list of currently registered credentials and the | ||
| current user details in the format these APIs expect. | ||
|
|
||
| For more information about these APIs, refer to the following resources: | ||
|
|
||
| - `PublicKeyCredential.signalCurrentUserDetails <https://developer.mozilla.org/en-US/docs/Web/API/PublicKeyCredential/signalCurrentUserDetails_static>`_ | ||
| - `PublicKeyCredential.signalAllAcceptedCredentials <https://developer.mozilla.org/en-US/docs/Web/API/PublicKeyCredential/signalAllAcceptedCredentials_static>`_ | ||
|
|
||
| .. note:: | ||
|
|
||
| As of November 2025, these APIs are still relatively new and don't enjoy | ||
| broad support from all browsers. Please see `Web authentication signal | ||
| methods on caniuse.com <https://caniuse.com/wf-webauthn-signals>`_ for the | ||
| most up-to-date browser support information. |
Collaborator
There was a problem hiding this comment.
We should move this to the Reference section of the docs and link to it here.
activus-d
reviewed
Nov 25, 2025
activus-d
previously requested changes
Nov 25, 2025
Collaborator
activus-d
left a comment
activus-d
left a comment
There was a problem hiding this comment.
Let's make this consistent with the preceding headings:
Refs: Stormbase#38 This uses the `PublicKeyCredential.signalCurrentUserDetails` and `PublicKeyCredential.signalAllAcceptedCredentials` browser apis to 'sync' user details like name and currently registered credentials. This is useful to stop the browser from suggesting a credential was removed and to ensure saved information like a username remains up-to-date.
And update `playwright_force_login` to use it.
To support waiting for multiple messages at the same time. This code was 90% generated by Copilot.
...during passkey verification through the button.
Don't need no noise.
`render_otp_webauthn_sync_signals_scripts`
Stormheg
force-pushed
the
feature/38-use-webauthn-signal-api
branch
from
7174f1b to
16c93e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #38