Skip to content

feat: broker connect validation #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tknikita wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: broker connect validation #198

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions module_utils/kafka_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,34 @@ def __init__(self, **configs):
self.connect_max_retry = configs.pop('connect_max_retry', 50)
kafka.client_async.BrokerConnection = CustomBrokerConnection
self.client = kafka.client_async.KafkaClient(**configs)

# Check connection to at least one broker before proceeding
# This prevents indefinite hanging when broker is unreachable
brokers = self.client.cluster.brokers()
if not brokers:
self.close()
raise UnableToRefreshState(
'No brokers available. Is your Kafka server running and '
'available on \'%s\'?' % configs.get('bootstrap_servers')
)

connected = False
for broker in brokers:
if self.connection_check(broker.nodeId):
connected = True
break

if not connected:
self.close()
raise UnableToRefreshState(
'Unable to connect to any broker. Is your Kafka server '
'running and available on \'%s\' with security protocol '
'\'%s\'?' % (
configs.get('bootstrap_servers'),
configs.get('security_protocol', 'PLAINTEXT')
)
)

self.refresh()

def init_zk_client(self):
Expand Down
Loading