FormStep visibilityRule from enableWhen

[pauljohanneskraft]

FormStep visibilityRule from enableWhen

♻️ Current situation & Problem

Currently, a nested item's enableWhen property is simply ignored. With these changes, we introduce a translation from the enableWhen property in FHIR to the visibilityRule property of a ORKFormStep.

⚙️ Release Notes

• Introduces visibilityRule generated from enableWhen property in a FHIR questionnaire

📚 Documentation

Please ensure that you properly document any additions in conformance to Spezi Documentation Guide.
You can use this section to describe your solution, but we encourage contributors to document your reasoning and changes using in-line documentation.

✅ Testing

Please ensure that the PR meets the testing requirements set by CodeCov and that new functionality is appropriately tested.
This section describes important information about the tests and why some elements might not be testable.

Code of Conduct & Contributing Guidelines

By creating and submitting this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

• I agree to follow the Code of Conduct and Contributing Guidelines.

[codecov]

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.84%. Comparing base (e4470f7) to head (f8d3729).

Files with missing lines	Patch %	Lines
...hKitOnFHIR/FHIRToResearchKit/NavigationRules.swift	83.34%	1 Missing ⚠️
...RToResearchKit/QuestionnaireItem+ResearchKit.swift	0.00%	1 Missing ⚠️

Additional details and impacted files

@@               Coverage Diff                @@
##           nested-skips      #91      +/-   ##
================================================
- Coverage         87.84%   85.84%   -2.00%     
================================================
  Files                28       28              
  Lines               485      487       +2     
================================================
- Hits                426      418       -8     
- Misses               59       69      +10     

Files with missing lines	Coverage Δ
...hKitOnFHIR/FHIRToResearchKit/NavigationRules.swift	88.24% <83.34%> (-5.51%)	⬇️
...RToResearchKit/QuestionnaireItem+ResearchKit.swift	52.39% <0.00%> (-7.61%)	⬇️

... and 1 file with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4470f7...f8d3729. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[PSchmiedmayer]

Looks good to me; would love to get an review from @vishnuravi as well 👍

[pauljohanneskraft]

Unfortunately, I have noticed that this implementation doesn't actually work... To really make this work, we would probably need to rewrite some parts of this library as a whole (e.g. we would need to have access to previously created steps within the task, which is not possible with the current setup). I actually planned to use enableWhen within questionnaires in ENGAGE-HF, but ultimately decided against using enableWhen for individual parts of steps and simply using it on a step-by-step level instead.

This is still definitely an interesting problem to solve, but I'm not sure, if I can do the whole refactoring very soon - happy to explain the problem in more detail though, if someone is willing to take this over!