Skip to content

convert FileWatchSensor to use threading over eventlent and stackstorm/logshipper#6373

Closed
skiedude wants to merge 1 commit intoStackStorm:masterfrom
skiedude:file_watch_sensor
Closed

convert FileWatchSensor to use threading over eventlent and stackstorm/logshipper#6373
skiedude wants to merge 1 commit intoStackStorm:masterfrom
skiedude:file_watch_sensor

Conversation

@skiedude
Copy link
Copy Markdown
Contributor

  1. Eventlet needs to go away, and its usage here was not useful to convert to gevent
  2. https://github.com/StackStorm/logshipper stops working in python3.12, just use threading
  3. The main readme still had incorrect information on how to use this sensor, but the sensors dir had the right way. Update main readme and remove sensor specific one

Tested locally with 3 rules watching 3 files using the example rule definition, as well as removing rules to confirm no new events were triggered for those removed rules/files.

image

@pull-request-size pull-request-size bot added the size/L PR that changes 100-499 lines. Requires some effort to review. label Mar 27, 2026
@skiedude skiedude closed this Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L PR that changes 100-499 lines. Requires some effort to review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant