Skip to content

Conversation

@spencerpatty
Copy link
Contributor

@spencerpatty spencerpatty commented Mar 20, 2025

Summary:

Adds default template for PRs, stored in .github/pull_request_template.md

Details:

@spencerpatty spencerpatty added the documentation Improvements or additions to documentation label Mar 20, 2025
@spencerpatty spencerpatty self-assigned this Mar 20, 2025
@spencerpatty spencerpatty requested a review from BenBrock March 20, 2025 03:49
@spencerpatty spencerpatty requested a review from yhmtsai March 20, 2025 04:00
BenBrock
BenBrock previously approved these changes Mar 20, 2025
Copy link
Collaborator

@BenBrock BenBrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@spencerpatty spencerpatty requested review from upsj and yhmtsai and removed request for upsj and yhmtsai March 20, 2025 04:00
yhmtsai
yhmtsai previously approved these changes Mar 20, 2025
@spencerpatty spencerpatty dismissed stale reviews from yhmtsai and BenBrock via bd1d47d March 20, 2025 15:14
Copy link
Collaborator

@BenBrock BenBrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@spencerpatty
Copy link
Contributor Author

ok, I have @BenBrock 's approval. and @yhmtsai had provided good feedback which I adjusted the PR from. Merging now

@spencerpatty spencerpatty merged commit 08649fe into main Mar 20, 2025
10 checks passed
@spencerpatty spencerpatty deleted the dev/spatty/add_default_pr_template branch March 20, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants