MAC Address handling fixes for updates with netbox 4.2+#391
Open
gs-adn wants to merge 2 commits intoSolvik:masterfrom
Open
MAC Address handling fixes for updates with netbox 4.2+#391gs-adn wants to merge 2 commits intoSolvik:masterfrom
gs-adn wants to merge 2 commits intoSolvik:masterfrom
Conversation
Both tools used to gather MAC addresses from devices (ethtool and /sys/class/net) return mac addresses as lowercase, but netbox normalizes them as uppercase, causing spurious MAC delete/re-creates when updating servers as the macs don't compare equal
MAC address objects are not necessarily unique in netbox, so when assigning the primary_interface_field match on the parent object to ensure uniqueness (example usecase: when using virtual VLAN interfaces on a physical interface, the children interface may use the same MAC. Then this update fails with an HTTP 400 because there are multiple netbox MAC address objects with the same MAC)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the netbox 4.2 changes to MAC address management, updating a server (with eg
--update-all) results in unnecessary deletion/recreation of mac addresses. Netbox normalizes all mac addresses to uppercase, while the tools used by netbox-agent (ethtool or/sys/class/net) return all addresses as lowercaseAlso with the 4.2 changes to MAC addresses, it's possible to have multiple MAC address objects in netbox with the same address, but assigned to different interfaces or different devices (notably for locally-administered mac addresses, or for virtual interfaces created as children from a physical interface where they inherit the parent MAC).
In that case, assigning the
primary_mac_addressattribute of interfaces will fail with an error:To avoid this, specify the interface the mac address is assigned to in the pynetbox request to restore uniqueness (
update_interface_macswill have created the MAC objects and assigned them to the interface before)