Fix support for uppercase letters in legacy codes#8627
Open
APickledWalrus wants to merge 2 commits intodev/patchfrom
Open
Fix support for uppercase letters in legacy codes#8627APickledWalrus wants to merge 2 commits intodev/patchfrom
APickledWalrus wants to merge 2 commits intodev/patchfrom
Conversation
APickledWalrus
added
the
bug
APickledWalrus
requested review from
Efnilite and
Pesekjak
and removed request for
a team
skriptlang-automation
Bot
added
the
needs reviews
This comment has been minimized.
This comment has been minimized.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Formatting with uppercase letters, such as
&Cand<##FFFF11>(only for double hashtag) no longer work.Solution
Updates the legacy regular expression patterns to work with uppercase letters.
Testing Completed
Adds JUnit tests for uppercase letters in formatting codes/tags.
Supporting Information
n/a
Completes:
Related: none
AI assistance: none