Adds ExprPlayerListOrder#8600
Open
AnOwlBe wants to merge 20 commits intoSkriptLang:dev/featurefrom
Open
Conversation
AnOwlBe
requested review from
Pesekjak and
TheMug06
and removed request for
a team
skriptlang-automation
Bot
added
needs reviews
This comment has been minimized.
This comment has been minimized.
sovdeeth
requested changes
Apr 28, 2026
skriptlang-automation
Bot
removed
the
needs triage
Author
|
oh I didn't see your additional comment after my reply yeah I think priority fits possibly weight? |
Member
|
Priority can probably stay, but you need a lot more explanation of this syntax in the description |
Author
|
Okay I made it more detailed |
…nts/expressions/ExprPlayerListPriority.java Co-authored-by: SirSmurfy2 <82696841+Absolutionism@users.noreply.github.com>
sovdeeth
approved these changes
Apr 28, 2026
Efnilite
requested changes
Apr 28, 2026
skriptlang-automation
Bot
removed
the
needs reviews
…nts/expressions/ExprPlayerListPriority.java Co-authored-by: Efnilite <35348263+Efnilite@users.noreply.github.com>
ShaneBeee
suggested changes
Apr 29, 2026
Contributor
ShaneBeee
left a comment
ShaneBeee
left a comment
There was a problem hiding this comment.
Just a few small nit picks. looks good otherwise :)
skriptlang-automation
Bot
added
the
needs reviews
ShaneBeee
approved these changes
Apr 29, 2026
Contributor
ShaneBeee
left a comment
ShaneBeee
left a comment
There was a problem hiding this comment.
Looks good to me.
One small note, just me being Picky McPicky Pants!
Otherwise looks good.
Thanks for doing those other changes.
…nts/expressions/ExprPlayerListPriority.java Co-authored-by: Shane Bee <shanebolenback@me.com>
sovdeeth
requested changes
Apr 29, 2026
skriptlang-automation
Bot
removed
the
needs reviews
…ayerListOrder # Conflicts: # src/main/java/org/skriptlang/skript/bukkit/entity/player/elements/expressions/ExprPlayerListPriority.java
APickledWalrus
requested changes
May 5, 2026
Member
APickledWalrus
left a comment
APickledWalrus
left a comment
There was a problem hiding this comment.
Looks really good so far! I like this feature
…nts/expressions/ExprPlayerListPriority.java Co-authored-by: Patrick Miller <apickledwalrus@icloud.com>
UnderscoreTud
approved these changes
May 6, 2026
APickledWalrus
requested changes
May 6, 2026
|
|
||
| @Override | ||
| public void change(Event event, Object @Nullable [] delta, ChangeMode mode) { | ||
| Integer amount = mode == ChangeMode.RESET ? null : (Integer) delta[0]; |
Member
There was a problem hiding this comment.
Rather than have amount be null, you can just use 0 (since that's the value RESET uses anyways). That should allow you to remove the assertions and even use int instead. You can replace mode == ChangeMode.RESET with delta == null if it still gives you issues with delta nullability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Its very useful as it grants ability for us to sort players on tab without need of teams.
Solution
Adds a ExprPlayerListOrder
with GET, SET & RESET for
acceptChange(did not add DELETE as that would not make sense unless it did same thing as RESET)Testing Completed
Tested on PaperMC 1.21.11 get, set, add, reset all work fine even with negative values
Supporting Information
Completes: none
Related: none
AI assistance: none