Replace connect event with new config-stage based events.#8597
Draft
sovdeeth wants to merge 1 commit intoSkriptLang:dev/featurefrom
Draft
Replace connect event with new config-stage based events.#8597sovdeeth wants to merge 1 commit intoSkriptLang:dev/featurefrom
sovdeeth wants to merge 1 commit intoSkriptLang:dev/featurefrom
Conversation
skriptlang-automation
Bot
added
the
needs triage
This comment has been minimized.
This comment has been minimized.
skriptlang-automation
Bot
removed
the
needs triage
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PlayerLoginEvent is deprecated and messed with the configuration stages of login. Since 1.21.7 a new system has been in place that we should update to,
Solution
Adds player being and complete login events, which will take the place of
on connect.on connectwill be deprecated.Adds new types to represent the player connections, which have player profiles, ips, and sometimes an Audience to send messages to.
Will add type property for UUID.
Testing Completed
Supporting Information
Completes: none
Related: none
AI assistance: none