Allow wait/halt to be used as a section

[ahmadmsaleem]

Problem

wait / halt only work as effects today, they block the entire trigger until the delay elapses. There is no way in Skript to schedule a block of code to run later while the rest of the trigger continues immediately.

Solution

Make Delay an EffectSection. EffectSectionEffect delegated setNext/getNext but not getActualNext or executionIntent, so Section.loadCode's intent walk stopped at the wrapper and missed trailing stop intents — letting inner delays leak past the section. Override both to delegate.

Effect form: unchanged.

Section form: body parses as a separate trigger under outer events with hasDelayBefore=TRUE. walk() snapshots locals, schedules the task, swaps locals in the callback so mutations stay isolated. Outer isn't delayed.

Testing Completed

Manual in game testing on a Paper server covering:

command /test1:
    trigger:
        broadcast "A"
        wait 1 second:
            broadcast "B"
            wait 2 seconds:
                broadcast "C"
            broadcast "D"
            wait 1 second
            broadcast "E"
        broadcast "F"
# expect: A, F, (1s) B, D, (2s) E, (3s) C


command /test2:
    trigger:
        set {_shared} to "outer"
        loop 3 times:
            set {_i} to loop-number
            wait 1 second:
                set {_shared} to "body-%{_i}%"
                broadcast "iter %{_i}% shared=%{_shared}% %unix timestamp of now%"
        wait 2 seconds
        broadcast "done shared=%{_shared}% %unix timestamp of now%"
# expect: (1s) 3 messages "iter 1..3" each with correct number and shared=body-N, (3s after start) done shared=outer


command /test3:
    trigger:
        broadcast "1"
        wait 2 seconds
        broadcast "2"
# expect: 1, (2s) 2 — effect form unchanged

> test1
[19:04:44 INFO]: A
[19:04:44 INFO]: F
[19:04:45 INFO]: B
[19:04:45 INFO]: D
[19:04:46 INFO]: E
[19:04:47 INFO]: C
> test2
[19:04:50 INFO]: iter 1 shared=body-1 1776272690.29
[19:04:50 INFO]: iter 2 shared=body-2 1776272690.29
[19:04:50 INFO]: iter 3 shared=body-3 1776272690.29
[19:04:51 INFO]: done shared=outer 1776272691.29
> test3
[19:04:53 INFO]: 1
[19:04:55 INFO]: 2

No skript test files added in this PR wait / halt do not currently have test scripts under src/test/skript/tests/ and adding the first ones for this feature felt out of scope. Happy to add them in a follow up

Supporting Information

This PR was made by eult :)

---

Completes: none
Related: none
AI assistance: Claude Opus 4.6, Used to help me writing the walk method, tests and rewrite the description

[TheLimeGlass]

That's a neat way to do it

[ahmadmsaleem]

That's a neat way to do it

this approach worked surprisingly well, idk how

[APickledWalrus]

Nice work so far

[sovdeeth]

looking good

[APickledWalrus]

The event is delayed regardless, no?

[APickledWalrus]

What's the purpose of this? I don't think the variable handling needs to be any different for sections.