Skip to content

Refactored location-finder code to follow the best practices - #540

Merged
sc-chathumikaalwis merged 3 commits into
Sitecore:dmzfrom
sc-esariupendri:alaris-refactor
Jun 15, 2026
Merged

Refactored location-finder code to follow the best practices#540
sc-chathumikaalwis merged 3 commits into
Sitecore:dmzfrom
sc-esariupendri:alaris-refactor

Conversation

@sc-esariupendri

@sc-esariupendri sc-esariupendri commented May 22, 2026

Copy link
Copy Markdown
Contributor

New example sites: This repository does not accept pull requests that add new example sites. If your change introduces a new top-level app under examples/ (or equivalent), it will be out of scope. To publish your own app, use the repo as a template or a fork. Details: Contributing: what we do not accept.

Description / Motivation

Please describe the context and motivation for this change. Why is this PR necessary? What problem does it solve or what feature does it add?
Include information on major design decisions, approaches taken, and any technical details important for reviewers to know.

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Explain how to test this PR. Include specific areas to test, relevant test cases, and any setup required.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Terms

@vercel

vercel Bot commented May 22, 2026

Copy link
Copy Markdown

@sc-esariupendri is attempting to deploy a commit to the Sitecore JSS Team on Vercel.

A member of the Team first needs to authorize it.

@sc-chathumikaalwis
sc-chathumikaalwis deleted the branch Sitecore:dmz May 28, 2026 06:25
@sc-chathumikaalwis
sc-chathumikaalwis changed the base branch from dmz to main June 15, 2026 05:10
@sc-chathumikaalwis
sc-chathumikaalwis changed the base branch from main to dmz June 15, 2026 05:47
@sc-chathumikaalwis
sc-chathumikaalwis merged commit c2fd7fc into Sitecore:dmz Jun 15, 2026
0 of 2 checks passed
sc-pamodithmaduwantha added a commit to sc-pamodithmaduwantha/xmcloud-starter-js-PM that referenced this pull request Jun 15, 2026
@sc-krishanthakumara @sc-nipunaabeywickrama
@sc-naveenhedallaarachchi @dependabot @sc-sobiyasivakumar @sc-shakyawijerathne @sc-pamodithmaduwantha @sc-chathumikaalwis @sc-esariupendri @sukiman
Dmz merge, Resolve conflicts and revert Alert Banner changes (#65)
657432b 
* Upgrade starter sites to CSDK 2.1.1 (Sitecore#541)

* feat: upgrade basic-nextjs, product-listing & skate-park to CSDK 2.1.0 (Sitecore#482)

* Upgrade Solterra and Alaris to CSDK 2.1.0 (Sitecore#481)

* upgrade solterra site

* upgrade alaris site to csdk 2.1.0

* refactor: simplify proxy function signatures and remove unused searchParams in page components

* chore(deps): update Next.js and various dependencies to latest versions

* chore(deps): update @sitecore-content-sdk/content, @sitecore-content-sdk/nextjs to 2.1.1, and other dependencies across multiple examples

---------

Co-authored-by: Naveen Hedalla Arachchi <nvhd@sitecore.net>

* chore(deps): bump the npm_and_yarn group across 7 directories with 5 updates (Sitecore#547)

Bumps the npm_and_yarn group with 1 update in the /examples/basic-nextjs directory: [tmp](https://github.com/raszi/node-tmp).
Bumps the npm_and_yarn group with 1 update in the /examples/basic-nextjs-pages-router directory: [tmp](https://github.com/raszi/node-tmp).
Bumps the npm_and_yarn group with 3 updates in the /examples/basic-spa/angular directory: [postcss](https://github.com/postcss/postcss), [ip-address](https://github.com/beaugunderson/ip-address) and [ws](https://github.com/websockets/ws).
Bumps the npm_and_yarn group with 1 update in the /examples/kit-nextjs-article-starter directory: [tmp](https://github.com/raszi/node-tmp).
Bumps the npm_and_yarn group with 2 updates in the /examples/kit-nextjs-location-finder directory: [next-intl](https://github.com/amannn/next-intl) and [tmp](https://github.com/raszi/node-tmp).
Bumps the npm_and_yarn group with 1 update in the /examples/kit-nextjs-product-listing directory: [tmp](https://github.com/raszi/node-tmp).
Bumps the npm_and_yarn group with 1 update in the /examples/kit-nextjs-skate-park directory: [tmp](https://github.com/raszi/node-tmp).


Updates `tmp` from 0.2.5 to 0.2.7
- [Changelog](https://github.com/raszi/node-tmp/blob/master/CHANGELOG.md)
- [Commits](raszi/node-tmp@v0.2.5...v0.2.7)

Updates `tmp` from 0.2.5 to 0.2.7
- [Changelog](https://github.com/raszi/node-tmp/blob/master/CHANGELOG.md)
- [Commits](raszi/node-tmp@v0.2.5...v0.2.7)

Updates `postcss` from 8.5.6 to 8.5.15
- [Release notes](https://github.com/postcss/postcss/releases)
- [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md)
- [Commits](postcss/postcss@8.5.6...8.5.15)

Updates `ip-address` from 10.1.0 to 10.2.0
- [Commits](beaugunderson/ip-address@v10.1.0...v10.2.0)

Updates `ws` from 8.18.3 to 8.20.1
- [Release notes](https://github.com/websockets/ws/releases)
- [Commits](websockets/ws@8.18.3...8.20.1)

Updates `tmp` from 0.2.5 to 0.2.7
- [Changelog](https://github.com/raszi/node-tmp/blob/master/CHANGELOG.md)
- [Commits](raszi/node-tmp@v0.2.5...v0.2.7)

Updates `next-intl` from 4.9.1 to 4.9.2
- [Release notes](https://github.com/amannn/next-intl/releases)
- [Changelog](https://github.com/amannn/next-intl/blob/main/CHANGELOG.md)
- [Commits](amannn/next-intl@v4.9.1...v4.9.2)

Updates `tmp` from 0.2.5 to 0.2.7
- [Changelog](https://github.com/raszi/node-tmp/blob/master/CHANGELOG.md)
- [Commits](raszi/node-tmp@v0.2.5...v0.2.7)

Updates `tmp` from 0.2.5 to 0.2.7
- [Changelog](https://github.com/raszi/node-tmp/blob/master/CHANGELOG.md)
- [Commits](raszi/node-tmp@v0.2.5...v0.2.7)

Updates `tmp` from 0.2.5 to 0.2.7
- [Changelog](https://github.com/raszi/node-tmp/blob/master/CHANGELOG.md)
- [Commits](raszi/node-tmp@v0.2.5...v0.2.7)

---
updated-dependencies:
- dependency-name: tmp
  dependency-version: 0.2.7
  dependency-type: indirect
  dependency-group: npm_and_yarn
- dependency-name: tmp
  dependency-version: 0.2.7
  dependency-type: indirect
  dependency-group: npm_and_yarn
- dependency-name: postcss
  dependency-version: 8.5.15
  dependency-type: indirect
  dependency-group: npm_and_yarn
- dependency-name: ip-address
  dependency-version: 10.2.0
  dependency-type: indirect
  dependency-group: npm_and_yarn
- dependency-name: ws
  dependency-version: 8.20.1
  dependency-type: indirect
  dependency-group: npm_and_yarn
- dependency-name: tmp
  dependency-version: 0.2.7
  dependency-type: indirect
  dependency-group: npm_and_yarn
- dependency-name: next-intl
  dependency-version: 4.9.2
  dependency-type: direct:production
  dependency-group: npm_and_yarn
- dependency-name: tmp
  dependency-version: 0.2.7
  dependency-type: indirect
  dependency-group: npm_and_yarn
- dependency-name: tmp
  dependency-version: 0.2.7
  dependency-type: indirect
  dependency-group: npm_and_yarn
- dependency-name: tmp
  dependency-version: 0.2.7
  dependency-type: indirect
  dependency-group: npm_and_yarn
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump ws from 8.18.3 to 8.20.1 in /examples/basic-spa (Sitecore#538)

Bumps [ws](https://github.com/websockets/ws) from 8.18.3 to 8.20.1.
- [Release notes](https://github.com/websockets/ws/releases)
- [Commits](websockets/ws@8.18.3...8.20.1)

---
updated-dependencies:
- dependency-name: ws
  dependency-version: 8.20.1
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Remove MultiPromo Primary Button variant (no React implementation) (Sitecore#539)

Co-authored-by: sc-sobiyasivakumar <sc-sobiyasivakumar@users.noreply.github.com>

* chore: update several dependancy versions in package.json files and sync the lock files to use the newest versions (Sitecore#546)

Co-authored-by: Pamodith Maduwantha <pamo@sitecore.net>

* Vulnerabilities fix (Sitecore#552)

* Update package-locks

* Chore(deps): update package-lock.json and package.json to reflect dependency changes

* chore(deps): update package-lock.json and package.json to reflect new versions of dependencies

* chore(deps): update qs to version 6.15.2 and bump other dependencies in package.json and package-lock.json

* chore(deps): update hono to version 4.12.18, brace-expansion to 5.0.6, and add uuid and webpack-dev-server dependencies in package.json and package-lock.json

* SYNC: Cleanup unused patterns, and fix config issues (Sitecore#544)

* fix(product-listing): removed font styles from layout, updated global styles, and TypeScript config

* fix(search-experience): update class from 'search-indexing' to 'search-experience'

* fix(theme): implement dark mode styles and update theme provider defaults

* Revert theme fixes

* Code refactor and improvements to `kit-nextjs-article-starter`  (Sitecore#551)

* refactor: simplify Providers component by removing unused props and context

* refactor: remove SiteMetadata component and related props since they are dead code

* refactor: update import paths to use absolute imports for better reliability

* feat: enhance Sitecore configuration with API and default settings

* refactor: clean up TypeScript configuration and update proxy matcher in kit-nextjs-article-starter (Sitecore#553)

* refactor: simplify Sitecore configuration by removing unused API settings in kit-nextjs-article-starter (Sitecore#554)

* Refactored location-finder code to follow the best practices (Sitecore#540)

* Refactored location-finder code to follow the best practices

* Standardize location-finder field shape access

* Add guidance for using props sidecars in component structure

---------

Co-authored-by: sc-esariupendri <236554266+sc-esariupendri@users.noreply.github.com>

* Refactored product-listing code to follow the best practices (Sitecore#542)

* Refactor search field handling to improve error management and support optional input

* Refactored product-listing code to follow the best practices

* Refactor next:dev script to include NODE_OPTIONS for debugging

* Field shape inconcistency  refactor

* Resolved test failures

* Refactor component props management: move props/interfaces to sidecar files and update Sitecore CLI config to exclude them from component-map generation.

---------

Co-authored-by: sc-esariupendri <236554266+sc-esariupendri@users.noreply.github.com>

* Refactored skate-park code to follow the best practices (Sitecore#550)

* Skate park refactor

* refactor: enhance compatibility of component props and improve field value retrieval

---------

Co-authored-by: sc-esariupendri <236554266+sc-esariupendri@users.noreply.github.com>

* fix: remove accidentally committed root SearchBox.tsx dead code (Sitecore#558)

* fix(location-finder): fix minimatch override to use scoped version constraint (Sitecore#562)

Co-authored-by: sc-krishanthakumara <sc-krishanthakumara@users.noreply.github.com>

* revert: use dmz version of AlertBanner test file

* fix: restore AlertBanner test as proper text file (dmz version)

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Nipuna Abeywickrama <nipu@sitecore.net>
Co-authored-by: Naveen Hedalla Arachchi <nvhd@sitecore.net>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sobiya Sivakumar <siva@sitecore.net>
Co-authored-by: sc-sobiyasivakumar <sc-sobiyasivakumar@users.noreply.github.com>
Co-authored-by: Shakya Wijerathne <shakya.wijerathne@sitecore.com>
Co-authored-by: Pamodith Maduwantha <pamo@sitecore.net>
Co-authored-by: Chathumika Alwis <ctlw@sitecore.net>
Co-authored-by: Esari Upendri <upen@sitecore.net>
Co-authored-by: sc-esariupendri <236554266+sc-esariupendri@users.noreply.github.com>
Co-authored-by: sukiman <sukiman.hung@gmail.com>
Co-authored-by: sc-krishanthakumara <sc-krishanthakumara@users.noreply.github.com>
sc-esariupendri added a commit to sc-esariupendri/xmcloud-starter-js that referenced this pull request Jun 17, 2026
@sc-esariupendri @sukiman
Code scan fixes (#100)
63df924 
* Refactored location-finder code to follow the best practices (Sitecore#540)

* Refactored location-finder code to follow the best practices

* Standardize location-finder field shape access

* Add guidance for using props sidecars in component structure

---------

Co-authored-by: sc-esariupendri <236554266+sc-esariupendri@users.noreply.github.com>

* Refactored product-listing code to follow the best practices (Sitecore#542)

* Refactor search field handling to improve error management and support optional input

* Refactored product-listing code to follow the best practices

* Refactor next:dev script to include NODE_OPTIONS for debugging

* Field shape inconcistency  refactor

* Resolved test failures

* Refactor component props management: move props/interfaces to sidecar files and update Sitecore CLI config to exclude them from component-map generation.

---------

Co-authored-by: sc-esariupendri <236554266+sc-esariupendri@users.noreply.github.com>

* Refactored skate-park code to follow the best practices (Sitecore#550)

* Skate park refactor

* refactor: enhance compatibility of component props and improve field value retrieval

---------

Co-authored-by: sc-esariupendri <236554266+sc-esariupendri@users.noreply.github.com>

* fix: remove accidentally committed root SearchBox.tsx dead code (Sitecore#558)

* feat: implement zipcode storage utility and update components to use it

---------

Co-authored-by: sc-esariupendri <236554266+sc-esariupendri@users.noreply.github.com>
Co-authored-by: sukiman <sukiman.hung@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sc-nipunaabeywickrama sc-nipunaabeywickrama sc-nipunaabeywickrama approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sc-esariupendri @sc-nipunaabeywickrama @sc-chathumikaalwis