fix: handle middle mouse button on click menu item#9772
Closed
H4ad wants to merge 1 commit intoSigNoz:mainfrom
Closed
fix: handle middle mouse button on click menu item#9772H4ad wants to merge 1 commit intoSigNoz:mainfrom
H4ad wants to merge 1 commit intoSigNoz:mainfrom
Conversation
|
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
ishan621
previously approved these changes
Jan 16, 2026
Contributor
ishan621
left a comment
ishan621
left a comment
There was a problem hiding this comment.
This will be a good addition to the overall user experience.
YounixM
force-pushed
the
perf/chart
branch
2 times, most recently
from
917cefd to
6431688
Compare
Contributor
Author
|
Closed in favor of #10350 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📄 Summary
Add support to open the new tab not only via CTRL but also via middle click of the button, like URL link.
✅ Changes
🧪 How to Test
🔍 Related Issues
I found no related issue.
📸 Screenshots / Screen Recording (if applicable / mandatory for UI related changes)
No screenshots since this change via click.
📋 Checklist
👀 Notes for Reviewers
Inspired by https://www.linkedin.com/feed/update/urn:li:activity:7400183369948520448?commentUrn=urn%3Ali%3Acomment%3A%28activity%3A7400183369948520448%2C7400648742405554176%29&dashCommentUrn=urn%3Ali%3Afsd_comment%3A%287400648742405554176%2Curn%3Ali%3Aactivity%3A7400183369948520448%29
Note
Low Risk
Low risk UI navigation change that broadens “open in new tab” behavior to include middle-click; potential risk is minor regressions in sidebar click handling (e.g., pin icon interactions).
Overview
Sidebar navigation now treats middle-click the same as Ctrl/Meta-click when deciding to
openInNewTab, via a sharedshouldMouseEventOpenInNewTabhelper used across menu handlers.NavItemalso triggers navigation ononMouseDownfor middle clicks (while still respecting disabled items and ignoring clicks on the pin icon) so middle-click works consistently on sidebar entries.Written by Cursor Bugbot for commit be22ce7. This will update automatically on new commits. Configure here.