Closed
Conversation
…ties The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-BABELRUNTIME-10044504 - https://snyk.io/vuln/SNYK-JS-BRACEEXPANSION-9789073
|
|
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Contributor
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to ff1ff0b in 1 minute and 14 seconds. Click for details.
- Reviewed
31lines of code in1files - Skipped
1files when reviewing. - Skipped posting
3draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. frontend/package.json:82
- Draft comment:
Upgraded jest to ^29.0.0. This is a major update – ensure that Jest configuration, custom setups, and type definitions (e.g., @types/jest) are updated accordingly. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is related to a dependency change, specifically the upgrade of Jest to a new major version. The comment advises the author to ensure that configurations and setups are updated accordingly. According to the rules, comments on dependency changes or asking the author to ensure things are not allowed. Therefore, this comment should be removed.
2. frontend/package.json:108
- Draft comment:
react-i18next bumped from ^11.16.1 to ^15.5.3. Verify that any breaking changes in the API are handled in your components. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is about a dependency change, specifically a version bump for the react-i18next library. The comment asks the author to verify breaking changes, which is against the rules for commenting on dependency changes.
3. frontend/package.json:132
- Draft comment:
webpack-dev-server upgraded from ^4.15.2 to ^5.1.0. Ensure that your dev server configuration complies with any changes introduced in version 5. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is related to a dependency change, specifically the upgrade of webpack-dev-server. The comment advises the PR author to ensure compatibility with the new version, which violates the rule against asking the author to ensure compatibility or test changes. Therefore, this comment should be removed.
Workflow ID: wflow_XySSNde02uIvh8dP
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Snyk has created this PR to fix 2 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
frontend/package.jsonfrontend/yarn.lockNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-BABELRUNTIME-10044504
SNYK-JS-BRACEEXPANSION-9789073
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Regular Expression Denial of Service (ReDoS)
Important
Upgrade
jest,react-i18next, andwebpack-dev-serverinfrontend/package.jsonto fix ReDoS vulnerabilities.jestfrom^27.5.1to^29.0.0infrontend/package.json.react-i18nextfrom^11.16.1to^15.5.3infrontend/package.json.webpack-dev-serverfrom^4.15.2to^5.1.0infrontend/package.json..yarn/cache/, requiringyarncommand for zero-install users.This description was created by
for ff1ff0b. You can customize this summary. It will automatically update as commits are pushed.