Closed
Conversation
…ties The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-WEBPACKDEVSERVER-10300775 - https://snyk.io/vuln/SNYK-JS-WEBPACKDEVSERVER-10300777 - https://snyk.io/vuln/SNYK-JS-BABELHELPERS-9397697
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
|
|
Contributor
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 61fb4e9 in 193 minutes and 59 seconds. Click for details.
- Reviewed
31lines of code in1files - Skipped
1files when reviewing. - Skipped posting
3draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. frontend/package.json:56
- Draft comment:
babel-jest updated to ^30.0.0. This is a major version bump; please verify that any custom Jest/babel configurations remain compatible. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%The comment is about a dependency version change, specifically a major version bump of babel-jest. The comment asks the author to verify compatibility, which is against the rules. The rules state not to comment on dependency changes or ask the author to verify compatibility.
2. frontend/package.json:83
- Draft comment:
Jest bumped to ^30.0.0 from ^27.5.1. Ensure that your tests and configuration work with the updated version. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is about a dependency change, specifically the Jest version. The rules specify not to comment on pure dependency changes or library versions that are not recognized. Therefore, this comment should be removed.
3. frontend/package.json:131
- Draft comment:
webpack-dev-server updated to ^5.2.1 from ^4.15.2. Confirm that the webpack configuration is updated to accommodate breaking changes introduced in v5. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is related to a dependency change, specifically the update of webpack-dev-server. The comment asks the PR author to confirm that the webpack configuration is updated for breaking changes, which violates the rule against asking for confirmation or verification of intentions. Therefore, this comment should be removed.
Workflow ID: wflow_g2xFFLOoTJfym10H
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Snyk has created this PR to fix 3 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
frontend/package.jsonfrontend/yarn.lockNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-WEBPACKDEVSERVER-10300775
SNYK-JS-WEBPACKDEVSERVER-10300777
SNYK-JS-BABELHELPERS-9397697
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Regular Expression Denial of Service (ReDoS)
Important
Fixes vulnerabilities by upgrading
babel-jest,jest, andwebpack-dev-serverinfrontend/package.json.babel-jestfrom^29.6.4to^30.0.0infrontend/package.json.jestfrom^27.5.1to^30.0.0infrontend/package.json.webpack-dev-serverfrom^4.15.2to^5.2.1infrontend/package.json.webpack-dev-server.webpack-dev-server.babel-helpers.yarnto update.yarn/cache/directory.This description was created by
for 61fb4e9. You can customize this summary. It will automatically update as commits are pushed.