This repository was archived by the owner on May 7, 2021. It is now read-only.
Open
Conversation
- Installs Guzzle latest version on Composer; - Renamed CurlRequest and CurlResponse to just Request/Response; - Changed all references to CurlRequest/Response to the reespective new name;
Contributor
Author
|
cc: @joshubrown |
Contributor
|
Thanks again for this Rodolfo. I'd like to avoid including Guzzle until we use it in the library — would you be able to add more to this then ping me for review? Looks good so far! |
Contributor
Author
|
I'll take a look @joshubrown |
|
The library should use psr7, if it does, then guzzle can be used as a drop-in. It's not right to enforce Guzzle any more than curl, even if we have and use both in our work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starts the effort to move from pure PHP CURL to Guzzle.